On 03/29/2020 04:03 AM, xiakaixu1987@xxxxxxxxx wrote: > --- > fs/xfs/xfs_symlink.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/xfs/xfs_symlink.c b/fs/xfs/xfs_symlink.c > index d762d42..3ad82c3 100644 > --- a/fs/xfs/xfs_symlink.c > +++ b/fs/xfs/xfs_symlink.c > @@ -176,7 +176,6 @@ > return -ENAMETOOLONG; > ASSERT(pathlen > 0); > > - udqp = gdqp = NULL; > prid = xfs_get_initial_prid(dp); > > /* > -- 1.8.3.1 Since these two variables are initialized at the time of declaration it make sense to remove this. Looks good. Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>