On Sun, Mar 29, 2020 at 07:03:35PM +0800, xiakaixu1987@xxxxxxxxx wrote: > From: Kaixu Xia <kaixuxia@xxxxxxxxxxx> > > The variables 'udqp' and 'gdqp' have been initialized, so remove > redundant variable assignment in xfs_symlink(). > > Signed-off-by: Kaixu Xia <kaixuxia@xxxxxxxxxxx> > --- > fs/xfs/xfs_symlink.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/xfs/xfs_symlink.c b/fs/xfs/xfs_symlink.c > index d762d42..3ad82c3 100644 > --- a/fs/xfs/xfs_symlink.c > +++ b/fs/xfs/xfs_symlink.c > @@ -176,7 +176,6 @@ > return -ENAMETOOLONG; > ASSERT(pathlen > 0); > > - udqp = gdqp = NULL; > prid = xfs_get_initial_prid(dp); Looks fine. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx