On Mon, Mar 23, 2020 at 02:06:57PM +0100, Christoph Hellwig wrote: > This series follows up on conversions about relogging infrastructure > and the way xfs_log_done() does two things but only one of several > callers uses both of those functions. It also pointed out that > xfs_trans_commit() never writes to the log anymore, so only > checkpoints pass a ticket to xlog_write() with this flag set and > no transaction makes multiple calls to xlog_write() calls on the > same ticket. Hence there's no real need for XLOG_TIC_INITED to track > whether a ticket has written a start record to the log anymore. > > A lot of further cleanups fell out of this. Once we no longer use > XLOG_TIC_INITED to carry state inside the write loop, the logic > can be simplified in both xlog_write and xfs_log_done. xfs_log_done > can be split up, and then the call chain can be flattened because > xlog_write_done() and xlog_commit_record() are basically the same. > > This then leads to cleanups writing both commit and unmount records. > > Finally, to complete what started all this, the XLOG_TIC_INITED flag > is removed. > > A git tree is avaiblable here: > > git://git.infradead.org/users/hch/xfs.git xlog-ticket-cleanup.2 > > Gitweb: > > http://git.infradead.org/users/hch/xfs.git/shortlog/refs/heads/xlog-ticket-cleanup.2 > > > Changes since v1: > - taking this over from Dave (for now) as he is still injured, an it > interacts closely with my log error handling bits > - rebased on top of for-next + the "more log cleanups" series > - fix an accounting error in xlog_write > - use a bool for the ticket header in xlog_write > - add a new patch to split xlog_ticket_done > This seems to ignore various bits of (trivial) feedback from v1 as well as drops all reviews... Brian
