On Tue, Mar 24, 2020 at 09:43:04AM +0100, Christoph Hellwig wrote: > On Thu, Mar 19, 2020 at 12:33:06PM +0800, Zorro Lang wrote: > > On Wed, Mar 18, 2020 at 06:21:15PM +0100, Christoph Hellwig wrote: > > > This test has constantly failed since it was added, and the promised > > > input validation never materialized. > > > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > > --- > > > > Hmm... that's truth this case always fails. But a mkfs.xfs sanity test is > > good. > > > > We have a RHEL internal mkfs.xfs sanity test case, but it takes long time to > > run, can't port to xfstests directly. > > I don't know if Jan would like to improve this case, might make it simple, > > remove those unstable test lines, rewrite the case to avoid unstable test > > results? Or we remove this case, then write a new one? > > I can do that too, if the xfs-devel thinks it worth. > > Fine with me, but we really need to get rid of tests failing for no > good reason. And given that there hasn't been any action for years > just removing this test seems like the by far best option. Yang Xu had sent patch[1] to fix xfs/191 last June, but it needed ack from XFS developers back then, and fell out off radar eventually. Do we want to pick & review it again? Thanks, Eryu [1] https://lore.kernel.org/fstests/1560929963-2372-1-git-send-email-xuyang2018.jy@xxxxxxxxxxxxxx/
