On Mon, Mar 16, 2020 at 01:00:31PM -0400, Brian Foster wrote: > AIL removal of the quotaoff start intent and free of both intents is > hardcoded to the ->iop_committed() handler of the end intent. Factor > out the start intent handling code so it can be used in a future > patch to properly handle quotaoff errors. Use xfs_trans_ail_remove() > instead of the _delete() variant to acquire the AIL lock and also > handle cases where an intent might not reside in the AIL at the > time of a failure. xfs_trans_ail_delete alsmost seems nicer here rather than duplicating the most be in ail except for abort/shutdown. But either way it looks correct, so if you prefer it this way: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
