On Mon, Mar 16, 2020 at 08:31:55AM -0700, Darrick J. Wong wrote: > diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c > index 337822115bbc..203e74fa64aa 100644 > --- a/fs/xfs/libxfs/xfs_alloc.c > +++ b/fs/xfs/libxfs/xfs_alloc.c > @@ -1514,7 +1514,7 @@ xfs_alloc_ag_vextent_lastblock( > * maxlen, go to the start of this block, and skip all those smaller > * than minlen. > */ > - if (len || args->alignment > 1) { > + if (*len || args->alignment > 1) { > acur->cnt->bc_ptrs[0] = 1; > do { > error = xfs_alloc_get_rec(acur->cnt, bno, len, &i); The change definitivelly restores the old behavior. Looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>