On Tue, Feb 25, 2020 at 03:09:42PM -0800, Christoph Hellwig wrote: > Also available as a git tree here: > > http://git.infradead.org/users/hch/xfs.git/shortlog/refs/heads/xfs-attr-cleanup.6 > > An xfsprogs tree porting over the libxfs changes is available here: > > http://git.infradead.org/users/hch/xfsprogs.git/shortlog/refs/heads/attr-cleanup > > > Changes since v5: > - don't move xfs_da_args Still looks fine to me... Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --D > Changes since v4: > - rename the attr_namespace field to attr_filter > - drop "properly type the buffer field in struct > xfs_fsop_attrlist_handlere", this was causing too much discussion for > a trivial cleanup > - improve a few commit messages and comments > - improve the ATTR_REPLACE checks a little more > - turn the xfs_forget_acl stub into an inline function > - fix a 0 vs NULL sparse warning in xfs_ioc_attr_list > > Changes since v3: > - clean up a cast > - fixup a comment > - fix a flags check to use the right flags (bisection only) > - move a few hunks around to better spots in the series > > Changes since v2: > - add more comments > - fix up an error handling corner case in __xfs_set_acl > - add more cowbell^H^H^H^H^H^H^Hbool > - add a new patch to reject invalid namespaces flags in > XFS_IOC_ATTRLIST_BY_HANDLE > - remove ATTR_ENTSIZE entirely > > Changes since v1: > - rebased to for-next, which includes the fixes from the first > version