Re: [PATCH 20/25] libxfs: remove dangerous casting between xfs_buf and cache_node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 25, 2020 at 09:52:16AM -0800, Christoph Hellwig wrote:
> >  #define XFS_BUF_SET_PRIORITY(bp,pri)	cache_node_set_priority( \
> >  						libxfs_bcache, \
> > -						(struct cache_node *)(bp), \
> > +						&(bp)->b_node, \
> >  						(pri))
> 
> I think this one would benefit from being turned into an inline
> function..

Yeah, probably both of those.

--D

> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux