> #define XFS_BUF_SET_PRIORITY(bp,pri) cache_node_set_priority( \ > libxfs_bcache, \ > - (struct cache_node *)(bp), \ > + &(bp)->b_node, \ > (pri)) I think this one would benefit from being turned into an inline function.. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>