On Fri, Feb 21, 2020 at 06:42:47AM -0800, Christoph Hellwig wrote: > On Wed, Feb 19, 2020 at 05:42:40PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > Create a separate namespace for libxfs_readbuf() flags so that it's a > > little more obvious when we're trying to use the "read or die" logic. > > Can we just kill this damn flag instead? Life would be much simpler > if the exit simply moved to the caller. It also kills the exit call > in a library anti-pattern (although of course due to being conditional > it isn't as bad as the real antipattern from the X11 libraries..) Heh. It was only now that I realized that there are ~8 callers of the "fail on ioerror" flag. Yes, let's get rid of them both. --D
