On Wed, Feb 19, 2020 at 05:42:40PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Create a separate namespace for libxfs_readbuf() flags so that it's a > little more obvious when we're trying to use the "read or die" logic. Can we just kill this damn flag instead? Life would be much simpler if the exit simply moved to the caller. It also kills the exit call in a library anti-pattern (although of course due to being conditional it isn't as bad as the real antipattern from the X11 libraries..)