On Wed, Feb 19, 2020 at 05:43:55PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > libxfs_writebuf is not a well named function -- it marks the buffer > dirty and then releases the caller's reference. The actual write comes > when the cache is flushed, either because someone explicitly told the > cache to flush or because we started buffer reclaim. > > Make the buffer release explicit in the callers and rename the function > to say what it actually does -- it marks the buffer dirty outside of > transaction context. FYI, before we made all buffer writes delwri or sync in the kernel the equivalent function was called xfs_buf_bawrite. But I'm not sure that was a better name. But maybe libxfs_buf_mark_dirty is a tad better? Otherwise looks good.
