On 2/17/20 7:38 AM, Christoph Hellwig wrote:
>> - struct xfs_quotainfo *q = mp->m_quotainfo;
>> struct xfs_disk_dquot *d = &dq->q_core;
>> struct xfs_def_quota *defq;
>> int prealloc = 0;
>>
>> ASSERT(d->d_id);
>> - defq = xfs_get_defquota(dq, q);
>> + defq = xfs_get_defquota(dq);
>
> Move this up to the declaration line while you're at it?
ok
>> {
>> struct xfs_dquot *dqp;
>> struct xfs_def_quota *defq;
>> @@ -554,7 +553,7 @@ xfs_qm_set_defquota(
>> return;
>>
>> ddqp = &dqp->q_core;
>> - defq = xfs_get_defquota(dqp, qinf);
>> + defq = xfs_get_defquota(dqp);
can't do that here. have to call xfs_qm_dqget_uncached(&dqp) first.
> Same here.
>
>> @@ -585,13 +585,12 @@ xfs_trans_dqresv(
>> xfs_qwarncnt_t warnlimit;
>> xfs_qcnt_t total_count;
>> xfs_qcnt_t *resbcountp;
>> - struct xfs_quotainfo *q = mp->m_quotainfo;
>> struct xfs_def_quota *defq;
>>
>>
>> xfs_dqlock(dqp);
>>
>> - defq = xfs_get_defquota(dqp, q);
>> + defq = xfs_get_defquota(dqp);
>
> And here.
I ... guess this doesn't have to be under the lock? I guess I'd rather not make
anything approaching a functional change in this otherwise cosmetic patch by moving
it tho.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>
