> - struct xfs_quotainfo *q = mp->m_quotainfo;
> struct xfs_disk_dquot *d = &dq->q_core;
> struct xfs_def_quota *defq;
> int prealloc = 0;
>
> ASSERT(d->d_id);
> - defq = xfs_get_defquota(dq, q);
> + defq = xfs_get_defquota(dq);
Move this up to the declaration line while you're at it?
> {
> struct xfs_dquot *dqp;
> struct xfs_def_quota *defq;
> @@ -554,7 +553,7 @@ xfs_qm_set_defquota(
> return;
>
> ddqp = &dqp->q_core;
> - defq = xfs_get_defquota(dqp, qinf);
> + defq = xfs_get_defquota(dqp);
Same here.
> @@ -585,13 +585,12 @@ xfs_trans_dqresv(
> xfs_qwarncnt_t warnlimit;
> xfs_qcnt_t total_count;
> xfs_qcnt_t *resbcountp;
> - struct xfs_quotainfo *q = mp->m_quotainfo;
> struct xfs_def_quota *defq;
>
>
> xfs_dqlock(dqp);
>
> - defq = xfs_get_defquota(dqp, q);
> + defq = xfs_get_defquota(dqp);
And here.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
