Re: [PATCH 20/31] xfs: open code ATTR_ENTSIZE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 17, 2020 at 01:59:46PM +0100, Christoph Hellwig wrote:
> Replace an opencoded offsetof and round_up hiden behind to macros
> using the open code variant using the standard helpers.

Could be better written (and typos):

Replace a single use macro containing open-coded variants of
standard helpers with direct calls to the standard helpers.

> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Chandan Rajendra <chandanrlinux@xxxxxxxxx>

Otherwise, looks OK.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux