On Mon, Feb 17, 2020 at 01:59:45PM +0100, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > fs/xfs/libxfs/xfs_attr.h | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_attr.h b/fs/xfs/libxfs/xfs_attr.h > index 0c8f7c7a6b65..31c0ffde4f59 100644 > --- a/fs/xfs/libxfs/xfs_attr.h > +++ b/fs/xfs/libxfs/xfs_attr.h > @@ -69,14 +69,6 @@ typedef struct attrlist_ent { /* data from attr_list() */ > char a_name[1]; /* attr name (NULL terminated) */ > } attrlist_ent_t; > > -/* > - * Given a pointer to the (char*) buffer containing the attr_list() result, > - * and an index, return a pointer to the indicated attribute in the buffer. > - */ > -#define ATTR_ENTRY(buffer, index) \ > - ((attrlist_ent_t *) \ > - &((char *)buffer)[ ((attrlist_t *)(buffer))->al_offset[index] ]) > - > /* > * Kernel-internal version of the attrlist cursor. > */ I'm surprised it lasted this long. :) Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx