On 2/11/20 3:08 AM, Carlos Maiolino wrote: >> + unlinked_ino = be32_to_cpu(dino->di_next_unlinked); >> + if (!xfs_verify_agino_or_null(mp, agno, unlinked_ino)) { >> + retval = 1; >> + if (!uncertain) >> + do_warn(_("bad next_unlinked 0x%x on inode %" PRIu64 "%c"), >> + (__s32)dino->di_next_unlinked, lino, > ^^^^ > shouldn't we be using be32_to_cpu() > here, instead of a direct casting to > __s32? Yes, good catch. I was looking at the version check which just does (__s8) but of course that doesn't need the conversion. I'll fix it here, thanks! -Eric