Re: [PATCH] xfs_repair: fix bad next_unlinked field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +	unlinked_ino = be32_to_cpu(dino->di_next_unlinked);
> +	if (!xfs_verify_agino_or_null(mp, agno, unlinked_ino)) {
> +		retval = 1;
> +		if (!uncertain)
> +			do_warn(_("bad next_unlinked 0x%x on inode %" PRIu64 "%c"),
> +				(__s32)dino->di_next_unlinked, lino,
				^^^^
				shouldn't we be using be32_to_cpu()
				here, instead of a direct casting to
				__s32?



Cheers.

-- 
Carlos




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux