On Sat, Jan 25, 2020 at 03:19:27PM -0800, Christoph Hellwig wrote: > On Thu, Jan 23, 2020 at 04:17:23PM -0800, Darrick J. Wong wrote: > > Fix all this stupidity by adding a for loop macro to take care of these > > details for us so that everyone can iterate all logical directory blocks > > (xfs_dir2_db_t) that start within a given bmbt record. > > No more magic macro in here (thankfully). But the rest looks good: Oops, yeah... Eric, if you decide to take this patch, could you please drop that second paragraph about the macro? > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thank you for the reviews! --D