On Sat, Jan 25, 2020 at 03:14:43PM -0800, Christoph Hellwig wrote: > On Wed, Jan 22, 2020 at 10:41:05AM -0600, Eric Sandeen wrote: > > Rather than randomly choosing locations for new #defines in the > > future, alphabetize the file now for consistency. > > This looks ok, but can we just kill off the stupid libxfs_ aliases > instead? They add absolutely no value. I volunteer to do the work. About the only use I have for them is xfs/437 which checks that we actually use the libxfs names and that we invert error codes correctly. So if you're going to kill the libxfs_* aliases you might as well make the error code sign consistent too. --D
