On Wed, Nov 13, 2019 at 08:12:50AM -0700, Allison Collins wrote: > What if I added an xfs_name_init to reduce LOC. and then dropped patch 3? > What would people think of that? I think we should just pass the da_args to the attr ops from the highest level and remove the churn of passing the xfs_name there. I've pushed out a compile tested only series here to illustrate what I mean: http://git.infradead.org/users/hch/xfs.git/shortlog/refs/heads/xfs-attr-cleanup