On Wed, Nov 06, 2019 at 06:27:46PM -0700, Allison Collins wrote: > This patch replaces the attribute name and length parameters with a > single struct xfs_name parameter. This helps to clean up the numbers of > parameters being passed around and pre-simplifies the code some. Does it? As-is the patch doesn't look too bad, although it adds more lines than it removes. But together with the next patch that embedds an xfs_name into the xfs_da_args structure and the now added memcpys it doesn't really look very helpful to me.