On Mon, Nov 11, 2019 at 05:38:10PM -0800, Darrick J. Wong wrote: > On Mon, Nov 11, 2019 at 07:09:57PM +0100, Christoph Hellwig wrote: > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > Heh, what was that even used for? > > - uint m_chsize; /* size of next field */ Inode cluster hash size. We used to keep a linked list of all the inodes in a cluster in a separate structure, so that we could easily iterate them when needed (writeback/cluster freeing). They were kept in a separate hash table so that they could be used as a quick reference inode cluster buffer cache as well (IIRC it was to speed up things like xfs_imap_to_bp()) without having the overhead of a full buffer cache lookup... The need for all this went away with the radix tree indexing and gang lookups - I guess I missed removing this last fragment. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
