On Mon, Nov 11, 2019 at 12:51:17AM -0800, Christoph Hellwig wrote: > I have to say I really hate the macro that includes the actual > if statement. Agreed, especially because it breaks coccinelle and other tools that don't deal well with random identifiers that "inexplicably" have statement blocks coming after them. > On Sun, Nov 10, 2019 at 05:18:05PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > The XFS_WANT_CORRUPT_* macros conceal subtle side effects such as the > > creation of local variables and redirections of the code flow. This is > > pretty ugly, so replace them with explicit if_xfs_meta_bad() tests that > > remove both of those ugly points. First we use Cocinelle to expand the > > macros into an if test and braces with the following coccinelle script: > > Also all this seems to be out of date. Yeah. --D
