On Thu, Nov 07, 2019 at 05:05:58PM -0800, Darrick J. Wong wrote: > > +static inline int > > +xfs_dir2_data_entsize( > > + struct xfs_mount *mp, > > + int namelen) > > Why not unsigned int here? Neither names nor entries can have negative > length. Other than that, looks fine... Ok, updated.