On Thu, Nov 07, 2019 at 04:57:00PM -0800, Darrick J. Wong wrote: > > struct xfs_dir2_data_entry *dent; > > struct xfs_buf *bp; > > struct xfs_dir2_leaf_entry *ent; > > - char *p, *endp; > > + void *endp; > > + unsigned int offset; > > Can this be named iter_off or something? There's already an @off variable > which is the offset-within-block that wa calculated from the entry pointer. Ok. > > + struct xfs_dir2_data_entry *dep = bp->b_addr + offset; > > + struct xfs_dir2_data_unused *dup = bp->b_addr + offset; > > + > > Extra whitespace. Fixed.
