On Thu, Nov 07, 2019 at 12:34:50AM -0800, Christoph Hellwig wrote: > > - while (xfs_btree_islastblock(acur.cnt, 0)) { > > + error = xfs_btree_islastblock(acur.cnt, 0, &is_last); > > + if (error) > > + goto out; > > + while (is_last) { > > This transformation looks actually ok, but is highly non-obvious. > I think you want a prep patch just killing the pointless while first. Yeah, killing the while was a little more involved than I thought it would be, but it's done. --D