On 11/6/19 12:52 PM, Darrick J. Wong wrote: > On Wed, Nov 06, 2019 at 12:45:55PM -0600, Eric Sandeen wrote: >> On 11/6/19 12:29 PM, Amir Goldstein wrote: >>>>> #define CHATTR_XFLAG_LIST "r"/*p*/"iasAdtPneEfSxC" >>>> >>>> /me wonders if this should have /*X*/ commented out the same way we do >>>> for "p". >>> >>> Sure. Eric, please let me know if you want a re-submit for this. >> >> Ummm I'll just stage it now and add it so I don't forget >> >> like: >> >> #define CHATTR_XFLAG_LIST "r"/*p*/"iasAdtPneEfS"/*X*/"xC" >> >> that, right? > > Right. Actually for consistent ordering w/ the array, I guess maybe #define CHATTR_XFLAG_LIST "r"/*p*/"iasAdtPneEfSxC"/*X*/ Thanks -Eric