Re: [PATCH 6/5] xfs_repair: print better information when metadata updates fail

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/30/19 12:52 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> If a metadata update fails during phase 6, we should print an error
> message that can be traced back to a specific line of code.  Also,
> res_failed spits out a general message about "xfs_trans_reserve failed",
> which is probably not where the failure happened.  Fix two incorrect
> call sites.

looks like mkfs could use a fix too,

        c = -libxfs_trans_commit(tp);
        if (c)
                res_failed(c);

but for this,

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

not sure if we care, but:

Fixes: f9c559f4e ("xfs_repair: invalidate dirty dir buffers when we zap a  directory")
Fixes: f2279d8de ("libxfs: check libxfs_trans_commit return values")






[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux