On Fri, Nov 01, 2019 at 01:26:49PM -0500, Eric Sandeen wrote:
> On 10/22/19 1:46 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> >
> > Reduce the severity of reports about successful metadata repairs. We
> > fixed the problem, so there's no action necessary on the part of the
> > system admin.
>
> Hm, ok. "we found corruption" seems quite important, but I guess it's
> not an operational error of the utility. *shrug*
We *fixed* corruption, meaning that the fs is ok now.
If we left corruption behind (either because the user gave us "-n" or
the repair failed) then we still yell about it on stderr.
> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> > ---
> > scrub/common.c | 2 +-
> > scrub/common.h | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> >
> > diff --git a/scrub/common.c b/scrub/common.c
> > index b41f443d..7632a8d8 100644
> > --- a/scrub/common.c
> > +++ b/scrub/common.c
> > @@ -48,7 +48,7 @@ static struct {
> > } err_levels[] = {
> > [S_ERROR] = { .string = "Error", .loglevel = LOG_ERR },
> > [S_WARN] = { .string = "Warning", .loglevel = LOG_WARNING },
> > - [S_REPAIR] = { .string = "Repaired", .loglevel = LOG_WARNING },
> > + [S_REPAIR] = { .string = "Repaired", .loglevel = LOG_INFO },
> > [S_INFO] = { .string = "Info", .loglevel = LOG_INFO },
> > [S_PREEN] = { .string = "Optimized", .loglevel = LOG_INFO }
>
> My OCD wants this in the same order as error_level, I'll change that
> on commit if it's ok w/ you. And if I remember.
<nod>
--D
> Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
>
> > };
> > diff --git a/scrub/common.h b/scrub/common.h
> > index 9a37e9ed..ef4cf439 100644
> > --- a/scrub/common.h
> > +++ b/scrub/common.h
> > @@ -18,8 +18,8 @@ bool xfs_scrub_excessive_errors(struct scrub_ctx *ctx);
> > enum error_level {
> > S_ERROR = 0,
> > S_WARN,
> > - S_REPAIR,
> > S_INFO,
> > + S_REPAIR,
> > S_PREEN,
> > };
> >
> >
