On Fri, Oct 11, 2019 at 05:41:45PM -0700, Darrick J. Wong wrote: > > -#else > > -#define xlog_state_callback_check_state(l) ((void)0) > > -#endif > > So, uh... does this debugging functionality just disappear? Is it > unnecessary? It's not clear (to me anyway) why it's ok for the extra > checking to go away. Lets ask the counter question: What kind of bug do you think this check would catch?