On Wed, 2019-10-09 at 07:52 -0700, Christoph Hellwig wrote: > On Wed, Oct 09, 2019 at 07:30:10PM +0800, Ian Kent wrote: > > fs/super.c | 97 +++++ > > fs/xfs/xfs_super.c | 926 +++++++++++++++++++++++--------- > > ------------ > > include/linux/fs_context.h | 5 > > 3 files changed, 587 insertions(+), 441 deletions(-) > > I am a little worried about the diffstat. A few more lines of code > more for a more abstract API seems fine, but +150 lines for no new > functionality is worrisome. > Right, that's an obvious and sensible sanity check. But don't forget the first two patches are there for people to use so they can test the series since they were not in the xfs-linux tree at the time. The first patch, to create the get_tree_bdev() function, has been dropped because it's now been merged and the xfs-linux tree has been updated. There's also the bug fix to that patch which Al has now pushed to Linus but is not yet in xfs-linux, so it's still present in the series. Without that first patch the diffstat is a bit better. fs/super.c | 5 fs/xfs/xfs_super.c | 926 +++++++++++++++++++++++++++------------------------- 2 files changed, 489 insertions(+), 442 deletions(-) at 47 lines and once the bug fix patch makes its way to xfs-linux this will be under 45 which might be ok since overall I think there's an additional function. Ian
