On Wed, Oct 09, 2019 at 07:30:10PM +0800, Ian Kent wrote: > fs/super.c | 97 +++++ > fs/xfs/xfs_super.c | 926 +++++++++++++++++++++++--------------------- > include/linux/fs_context.h | 5 > 3 files changed, 587 insertions(+), 441 deletions(-) I am a little worried about the diffstat. A few more lines of code more for a more abstract API seems fine, but +150 lines for no new functionality is worrisome.