On Wed, Oct 09, 2019 at 11:38:24PM -0700, Christoph Hellwig wrote:
> On Wed, Oct 09, 2019 at 12:47:47PM -0700, Darrick J. Wong wrote:
> > On Wed, Oct 09, 2019 at 08:02:06AM -0700, Christoph Hellwig wrote:
> > > On Wed, Oct 09, 2019 at 07:30:52PM +0800, Ian Kent wrote:
> > > > +#ifndef CONFIG_XFS_QUOTA
> > > > + if (XFS_IS_QUOTA_RUNNING(mp)) {
> > > > + xfs_warn(mp, "quota support not available in this kernel.");
> > > > + return -EINVAL;
> > > > + }
> > > > +#endif
> > >
> > > this can use IS_ENABLED.
> >
> > I didn't think that macro needed a CONFIG_XFS_QUOTA check...?
>
> Even better if we don't need anything at al..
Actually. The test is and #ifndef, so yes we ctually need the check.
That being said I think and opencoded m_qflags != 0 instead of
XFS_IS_QUOTA_RUNNING would actually describing the intent to the
reader as we directly manipulate m_qflags elsewhere in the mount
code.
