On Wed, Oct 09, 2019 at 12:47:47PM -0700, Darrick J. Wong wrote: > On Wed, Oct 09, 2019 at 08:02:06AM -0700, Christoph Hellwig wrote: > > On Wed, Oct 09, 2019 at 07:30:52PM +0800, Ian Kent wrote: > > > +#ifndef CONFIG_XFS_QUOTA > > > + if (XFS_IS_QUOTA_RUNNING(mp)) { > > > + xfs_warn(mp, "quota support not available in this kernel."); > > > + return -EINVAL; > > > + } > > > +#endif > > > > this can use IS_ENABLED. > > I didn't think that macro needed a CONFIG_XFS_QUOTA check...? Even better if we don't need anything at al..