Re: [PATCH v5 13/17] xfs: mount api - add xfs_reconfigure()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2019-10-09 at 08:05 -0700, Christoph Hellwig wrote:
> > +/*
> > + * Logically we would return an error here to prevent users
> > + * from believing they might have changed mount options using
> > + * remount which can't be changed.
> > + *
> > + * But unfortunately mount(8) adds all options from mtab and
> > + * fstab to the mount arguments in some cases so we can't
> > + * blindly reject options, but have to check for each specified
> > + * option if it actually differs from the currently set option
> > + * and only reject it if that's the case.
> > + *
> > + * Until that is implemented we return success for every remount
> > + * request, and silently ignore all options that we can't actually
> > + * change.
> > + */
> 
> Please use up all 80 chars available for your comments.

Will do.

Ian




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux