Re: [PATCH v5 10/17] xfs: mount-api - add xfs_get_tree()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2019-10-09 at 08:04 -0700, Christoph Hellwig wrote:
> > +	/*
> > +	 * set up the mount name first so all the errors will refer to
> > the
> > +	 * correct device.
> > +	 */
> > +	mp->m_fsname = kstrndup(sb->s_id, MAXNAMELEN, GFP_KERNEL);
> > +	if (!mp->m_fsname)
> > +		goto out_error;
> > +	mp->m_fsname_len = strlen(mp->m_fsname) + 1;
> 
> m_fsname_len is entirelt unused.  m_fsname just has a few users, so
> maybe in a prep patch just kill both of them and use sb->s_id
> instead.

Ok, I'll also have a look at doing that.

Ian




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux