On 9/19/19 12:38 PM, Christoph Hellwig wrote: > On Thu, Sep 19, 2019 at 12:20:47PM -0500, Bill O'Donnell wrote: >>>> @@ -391,7 +396,7 @@ xfs_buf_allocate_memory( >>>> struct page *page; >>>> uint retries = 0; >>>> retry: >>>> - page = alloc_page(gfp_mask); >>>> + page = alloc_page(gfp_mask | kmflag_mask); >>> >>> alloc_page takes GFP_ flags, not KM_. In fact sparse should have warned >>> about this. >> >> I wondered if the KM flag needed conversion to GFP, but saw no warning. > > I'd be tempted to just do a manual memset after either kind of > allocation. At some point I think Dave had suggested that at least when allocating pages, using the flag would be more efficient? -Eric
