On Thu, Sep 19, 2019 at 12:20:47PM -0500, Bill O'Donnell wrote: > > > @@ -391,7 +396,7 @@ xfs_buf_allocate_memory( > > > struct page *page; > > > uint retries = 0; > > > retry: > > > - page = alloc_page(gfp_mask); > > > + page = alloc_page(gfp_mask | kmflag_mask); > > > > alloc_page takes GFP_ flags, not KM_. In fact sparse should have warned > > about this. > > I wondered if the KM flag needed conversion to GFP, but saw no warning. I'd be tempted to just do a manual memset after either kind of allocation.