On Wed, Sep 18, 2019 at 06:50:00PM +0200, Christoph Hellwig wrote: > On Mon, Sep 16, 2019 at 08:53:23AM -0400, Brian Foster wrote: > > Didn't Dave have a variant of this patch for dealing with a > > fragmentation issue (IIRC)? Anyways, seems fine: > > I don't really remember one. But maybe Dave can chime in. He did[1], but IIRC the discussion petered out because we didn't have a good way to measure the long term fragmentation effects of doing this. I sent in a second patch[2] that only trimmed posteof blocks the first time a file is closed, which reduced fragmentation dramatically on workloads where there are a lot of synchronous open-append-close writes (e.g. logging daemons). None of that stuff ever got merged, so maybe it's time to revisit these. --D [1] https://lore.kernel.org/linux-xfs/20190207050813.24271-2-david@xxxxxxxxxxxxx/ [2] https://lore.kernel.org/linux-xfs/155259894034.30230.7188877605950498518.stgit@magnolia/
