Hi all, Al Viro pointed out a while ago that while ->release returns an errno it is never checked and rather pointless. He pointed to XFS as an instance that can return one. This cleans up the code including remove the separate xfs_release helper, and also tacks on another fixlet to only release our write related resources when the file actually was opened for writing.
