On Mon, Sep 16, 2019 at 08:53:11AM -0400, Brian Foster wrote: > The caller might not care if this call generates errors, but shouldn't > we care if something fails? IOW, perhaps we should have an exit path > with a WARN_ON_ONCE() or some such to indicate that an unhandled error > has occurred..? Not sure there is much of a point. Basically all errors are either due to a forced shutdown or cause a forced shutdown anyway, so we'll already get warnings.