On Tue, Jul 23, 2019 at 01:38:08PM -0400, Jeff Layton wrote: > Ahh ok, I get it now. You're using it as a generic "free this, no matter > what it is" wrapper, and relying on the caller to ensure that it will > never try to free a vmalloc'ed addr from an atomic context. > > I wonder how many other places are doing that? I count 858 call sites > for kvfree. If significant portion of those are doing this, then we may > have to re-think my patch. It seems like the right thing to do, but we > there may be more fallout than I expected. For xfs we only have 4 direct callers of kmem_alloc_large, and 8 callers of kmem_zalloc_large, so it they aren't too many, even assuming that due to error handling we usually have a few more sites that free the buffers.
