On Wed, Jun 19, 2019 at 02:19:08PM +0200, Christoph Hellwig wrote: > The build/test bot found an issue with this one leading to crashes > at unmount, and I think this incremental patch should fix it: I have't see any crashes at unmount; would you mind sharing the report? --D > diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c > index 66b87cce69b9..c66757251809 100644 > --- a/fs/xfs/xfs_log.c > +++ b/fs/xfs/xfs_log.c > @@ -1954,7 +1954,6 @@ xlog_dealloc_log( > int i; > > xlog_cil_destroy(log); > - destroy_workqueue(log->l_ioend_workqueue); > > /* > * Cycle all the iclogbuf locks to make sure all log IO completion > @@ -1976,6 +1975,7 @@ xlog_dealloc_log( > } > > log->l_mp->m_log = NULL; > + destroy_workqueue(log->l_ioend_workqueue); > kmem_free(log); > } /* xlog_dealloc_log */ >
