On Mon, May 20, 2019 at 03:08:44PM -0700, Darrick J. Wong wrote: > > -xlog_state_do_callback( > > - struct xlog *log, > > - int aborted, > > - struct xlog_in_core *iclog); > > +STATIC void xlog_state_done_syncing( > > + struct xlog_in_core *iclog, > > + bool aborted); > > I totally mistook this for a function definition. :/ > > STATIC void xlog_state_done_syncing(struct xlog_in_core *iclog, bool aborted); > > ...seems to fit on one line, right? Yes, but this style is used by all the forward declarations in xfs_log.c. Eventually we should fix them all, or even better get rid of most of them.
