On Thu, May 23, 2019 at 09:28:59AM +1000, Dave Chinner wrote: > Yeah, that'll make it heaps easier to deal with. I'd rename "bp" in > that patch to something like "bufp" so it's not easily confused with > a xfs_buf bp, but otherwise it looks good. I had that in my original unpublished version, but it seemed to create a lot of churn. I'll throw it in as an additional cleanup patch at the end.