On Wed, May 22, 2019 at 07:31:32PM +0200, Christoph Hellwig wrote: > Does this look fine to you? > > http://git.infradead.org/users/hch/xfs.git/commitdiff/8d9600456c6674453dddd5bf36512658c39d7207 Yeah, that'll make it heaps easier to deal with. I'd rename "bp" in that patch to something like "bufp" so it's not easily confused with a xfs_buf bp, but otherwise it looks good. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx