On Mon, May 20, 2019 at 09:27:37AM -0400, Bryan Gurney wrote: > It's probably to guard against an assignment in a while / if / etc. statement. > > In other words: Are you sure you didn't intend the following? > > while (ctx == list_first_entry_or_null(list, > struct xfs_cil_ctx, iclog_entry)) { > > (I've stumbled on a bug like this before, so I figured I'd ask, just > to be certain.) Yes, I'm sure. I'm iterating the list to remove each entry from it from start to end.