On Fri, May 17, 2019 at 10:06:54AM -0400, Brian Foster wrote: > Nice cleanup overall. This removes a ton of duplicated and boilerplate > code. One thing I don't like is the loss of information around the use > of XFS_ITEM_PINNED in all these ->iop_push() calls associated with > intents. I'd almost rather see a generic xfs_intent_item_push() defined > somewhere and wire that up to these various calls. I don't particularly like that idea, for one because it adds so much boilerplate code to the intents, but also because if you logically thing about it - if an item can't be pushed it kinda is per defintion pinned, so I think this default makes sense. > Short of that, could > we at least move some of the information from these comments to the push > call in xfsaild_push_item()? For example.... Sure, I can do that.
