On Fri, May 17, 2019 at 01:26:59PM -0500, Eric Sandeen wrote: > > On 5/17/19 2:31 AM, Christoph Hellwig wrote: > > There is no good reason to keep these two functions separate. > > hm, do the thin ->create_done() wrappers make sense either? > > /* Get an EFD so we can process all the free extents. */ > STATIC void * > xfs_extent_free_create_done( > struct xfs_trans *tp, > void *intent, > unsigned int count) > { > return xfs_trans_get_efd(tp, intent, count); > } > > should we just hook xfs_trans_get_FOO() directly to ->create_done? Well, we have another callers of those in the log recovery code. I have some ideas how to clean some of this up, but that is too much for this series.